Skip to content

Bump the testing-library group across 1 directory with 2 updates #3911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koesie10 merged 1 commit into from
Apr 17, 2025
Merged

Bump the testing-library group across 1 directory with 2 updates #3911

koesie10 merged 1 commit into from
Apr 17, 2025

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 23, 2025 •
edited
Loading

Bumps the testing-library group with 2 updates in the /extensions/ql-vscode directory: @testing-library/react and @testing-library/user-event.

Updates @testing-library/react from 16.1.0 to 16.2.0

Release notes

Sourced from @​testing-library/react's releases.

v16.2.0

16.2.0 (2025-01-15)

Features

Commits

Updates @testing-library/user-event from 14.5.2 to 14.6.1

Release notes

Sourced from @​testing-library/user-event's releases.

v14.6.1

14.6.1 (2025-01-21)

Bug Fixes

  • correct description for delay option (#1175) (2edf14d)
  • keyboard: add ContextMenu to defaultKeyMap (#1079) (3e471d1)
  • keyboard: add brackets to defaultKeyMap (#1226) (543ecb0)
  • keyboard: walk through radio group per arrow keys (#1049) (bf8111c)
  • pointer: dispatch mouse events if pointerdown is defaultPrevented (#1121) (f681f7b)
  • pointer: set button and buttons properties on PointerEvent (#1219) (6614f72)
  • pointer: use 1 as default value for PointerEvent.width and PointerEvent.height (#1224) (f0468d0)
  • prevent click event loop on form-associated custom element (#1238) (465fc7e)
  • prevent click event on non-focusable control (#1130) (e429094)
  • upload: apply accept filter more leniently (#1064) (a344ad4)

v14.6.0

14.6.0 (2025-01-15)

Features

Bug Fixes

  • clipboard: await DataTransferItem.getAsString() callback (#1251) (7b11b0e)
  • event: assign pointer coords to MouseEvent (#1039) (8528972)
  • pointer: check PointerCoords.x in isDifferentPointerPosition (#1216) (75edef5)
  • pointer: check all fields of PointerCoords in isDifferentPointerPosition() (#1229) (5f3d28f)
Commits
  • d42954b chore: fix typos (#1260)
  • 465fc7e fix: prevent click event loop on form-associated custom element (#1238)
  • 65c1f6c test: update snapshots (#1261)
  • 543ecb0 fix(keyboard): add brackets to defaultKeyMap (#1226)
  • f0468d0 fix(pointer): use 1 as default value for PointerEvent.width and `PointerE...
  • 6614f72 fix(pointer): set button and buttons properties on PointerEvent (#1219)
  • 2edf14d fix: correct description for delay option (#1175)
  • e429094 fix: prevent click event on non-focusable control (#1130)
  • f681f7b fix(pointer): dispatch mouse events if pointerdown is defaultPrevented (#...
  • 3e471d1 fix(keyboard): add ContextMenu to defaultKeyMap (#1079)
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner January 23, 2025 13:36
@dependabot dependabot bot added the Update dependencies Dependabot update PRs label Jan 23, 2025
@dependabot dependabot bot mentioned this pull request Jan 23, 2025
Closed
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch 3 times, most recently from 404db93 to 9ff4795 Compare January 30, 2025 16:12
robertbrignull
robertbrignull previously approved these changes Jan 30, 2025
View reviewed changes
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch from 9ff4795 to 9ccb1c9 Compare January 30, 2025 16:14
@robertbrignull robertbrignull dismissed their stale review January 30, 2025 16:16

Tests are failing

@koesie10
Copy link
Member

koesie10 commented Feb 4, 2025

Most of these failing tests seem to be caused by this line in @microsoft/fast-foundation: https://github.com/microsoft/fast/blob/%40microsoft/fast-foundation_v2.50.0/packages/web-components/fast-foundation/src/anchor/anchor.ts#L139C13-L141

@microsoft/fast-foundation seems to be unsupported and won't have any future updates: microsoft/fast#6996. However, it's still a dependency of @vscode/webview-ui-toolkit, which seemingly has also been deprecated: microsoft/vscode-webview-ui-toolkit#561

We should migrate away from @vscode/webview-ui-toolkit, after which we might be able to upgrade these packages.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch 2 times, most recently from 1e4f30a to 3e029cc Compare February 6, 2025 13:50
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch 2 times, most recently from 01aa835 to c460334 Compare February 13, 2025 13:56
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch 4 times, most recently from 695b3fa to a6f50ee Compare February 27, 2025 13:06
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch from a6f50ee to 94553d3 Compare March 6, 2025 13:45
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch from 94553d3 to 45f5acb Compare March 13, 2025 13:50
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch 2 times, most recently from 5e34a34 to 137d7dc Compare March 27, 2025 13:51
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch 2 times, most recently from b4c5a17 to 03d8e46 Compare April 10, 2025 13:28
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch from 03d8e46 to 648fa97 Compare April 17, 2025 13:23
@koesie10
Copy link
Member

koesie10 commented Apr 17, 2025

@dependabot recreate

@dependabot
Bump the testing-library group across 1 directory with 2 updates
f333a9a 
Bumps the testing-library group with 2 updates in the /extensions/ql-vscode directory: [@testing-library/react](https://github.com/testing-library/react-testing-library) and [@testing-library/user-event](https://github.com/testing-library/user-event).


Updates `@testing-library/react` from 16.1.0 to 16.2.0
- [Release notes](https://github.com/testing-library/react-testing-library/releases)
- [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md)
- [Commits](testing-library/react-testing-library@v16.1.0...v16.2.0)

Updates `@testing-library/user-event` from 14.5.2 to 14.6.1
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md)
- [Commits](testing-library/user-event@v14.5.2...v14.6.1)

---
updated-dependencies:
- dependency-name: "@testing-library/react"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: testing-library
- dependency-name: "@testing-library/user-event"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: testing-library
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch from 648fa97 to f333a9a Compare April 17, 2025 14:46
koesie10
koesie10 approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've migrated away from @vscode/webview-ui-toolkit, I would expect these tests to pass, so we can merge this.

@koesie10 koesie10 enabled auto-merge April 17, 2025 15:11
@koesie10 koesie10 merged commit 861e4bd into main Apr 17, 2025
27 of 29 checks passed
@koesie10 koesie10 deleted the dependabot/npm_and_yarn/extensions/ql-vscode/testing-library-814a465a27 branch April 17, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

@robertbrignull robertbrignull robertbrignull left review comments

Assignees

No one assigned

Labels

Update dependencies Dependabot update PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koesie10 @robertbrignull